On Tue, Mar 16, 2004 at 11:09:28PM +0900, Atsushi Nemoto wrote: > sjhill> The 'r4k_dma_cache_wback_inv' function will fail when the > sjhill> requested size equals 0 AND when the address is a multiple of > sjhill> the line size. I discovered this bug while using the National > sjhill> Semiconductor DP8381x series PCI ethernet driver. I have > sjhill> attached a test program showing the bug as well as a patch for > sjhill> comment. Okay to apply? > > I think your patch is overkill. It flushes many one line then needed. So far I was simply considering any use with size 0 a bug. In this case a 0 argument was passed to pci_unmap_XXX, so I'll have to figure out with the other architecture maintainers if that's just odd usage of the API or an outright bug. Ralf
