Re: [PATCH] [RFC] r4k_dma_cache_wback_inv function fails when size=0...

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> On Mon, 15 Mar 2004 12:08:48 -0500, "Steven J. Hill" <sjhill@realitydiluted.com> said:

sjhill> The 'r4k_dma_cache_wback_inv' function will fail when the
sjhill> requested size equals 0 AND when the address is a multiple of
sjhill> the line size. I discovered this bug while using the National
sjhill> Semiconductor DP8381x series PCI ethernet driver. I have
sjhill> attached a test program showing the bug as well as a patch for
sjhill> comment. Okay to apply?

I think your patch is overkill.  It flushes many one line then needed.

How about just inserting

	if (unlikely(size == 0))
		return;

in beginning of each function?

---
Atsushi Nemoto


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux