On Wed, 21 Jan 2004, Jun Sun wrote:
> conswitchp needs to be set whenever CONFIG_VT is selected.
> Currently this job is done individually by each board in its setup
> routine, often in a wrong way.
>
> The right thing to do is to set the pointer in the common code
> and remove almost two dozens of duplicated and often wrong settings.
>
> The attached patch is for illustration only. The removal of board settings
> is not complete.
>
> Comments? Objections and cheers are equally welcome. :)
| --- linux/arch/mips/kernel/setup.c.orig Tue Nov 18 10:01:24 2003
| +++ linux/arch/mips/kernel/setup.c Wed Jan 21 16:00:47 2004
| @@ -471,6 +472,15 @@
| set_c0_status(ST0_CU0|ST0_KX|ST0_SX|ST0_FR);
| #endif
|
| +#ifdef CONFIG_VT
| +#if defined(CONFIG_VGA_CONSOLE)
| + conswitchp = &vga_con;
| +#elif defined(CONFIG_DUMMY_CONSOLE)
| + conswitchp = &dummy_con;
| +#endif
| +#endif
Isn't the #ifdef CONFIG_VT superfluous?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
