On Thu, Aug 14, 2003 at 06:35:28PM +0200, Maciej W. Rozycki wrote: > On Thu, 14 Aug 2003, Jun Sun wrote: > > > I am completely lost in your arguments. Let us keep it to the basic. > > > > Tell me what is wrong with the following, and why your proposal > > is better than this: > > > > 1) get rid of calibrate_*() function > > 2) introduce a generic counter frequence calibration routine, which > > is only invoked when mips_counter_frequency is 0. > > 3) If any board is not happy with this calibration, it is free to > > do its calibration in board_timer_init(), which would set > > mips_counter_frequency to be non-zero. > > So I am lost, too. What I proposed with the patch is exactly what you > describe above. So what's wrong with it? > Oh, really? :) 1) I don't see you " get rid of calibrate_*() function" 2) oh, why? because your "generic counter frequence" is not generic - it requires board-specific routines. I was referring to using jiffies to calibrate frequency. 3) I also don't see picky boards "do its calibration in board_timer_init()". Your proposal differs in every count. :) Jun
