Ralf Baechle wrote: > On Wed, Oct 02, 2002 at 03:40:27PM +0200, Maciej W. Rozycki wrote: > > > As a side note -- arch/mips64/kernel/linux32.c is a huge collection of > > often unrelated functions. It might be beneficial to split the file > > functionally, e.g. into fs32.c, net32.c, etc. or even with a finer grain, > > preferably in a subdirectory, e.g. arch/mips64/linux32/. What do you > > think? > > Much of the code is so generic it almost deserves to live in a directory > even higher in the hierarchy. If you look at the 32-bit compat code for > the various 64-bit architectures of Linux (in particular sparc64 and ia64), > it's a single huge cut'n'paste session. Not much of that code is actually > architecture dependant. That would be even better, but unfortunately a lot of the structures used in the compat code is not exactly the same across architectures :-( But it should be possible to merges a lot this stuff into a generic (architecture independent) set of functions. > > Ralf -- _ _ ____ ___ Carsten Langgaard Mailto:carstenl@mips.com |\ /|||___)(___ MIPS Denmark Direct: +45 4486 5527 | \/ ||| ____) Lautrupvang 4B Switch: +45 4486 5555 TECHNOLOGIES 2750 Ballerup Fax...: +45 4486 5556 Denmark http://www.mips.com
