On Tue, Apr 24, 2018 at 08:17:06AM +0300, Julian Anastasov wrote: > > Hello, > > On Mon, 23 Apr 2018, Cong Wang wrote: > > > Similarly, tbl->entries is not initialized after kmalloc(), > > therefore causes an uninit-value warning in ip_vs_lblc_check_expire(), > > as reported by syzbot. > > > > Reported-by: <syzbot+3e9695f147fb529aa9bc@xxxxxxxxxxxxxxxxxxxxxxxxx> > > Cc: Simon Horman <horms@xxxxxxxxxxxx> > > Cc: Julian Anastasov <ja@xxxxxx> > > Cc: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> > > Signed-off-by: Cong Wang <xiyou.wangcong@xxxxxxxxx> > > Thanks! > > Acked-by: Julian Anastasov <ja@xxxxxx> Thanks. Pablo, could you take this into nf? Acked-by: Simon Horman <horms@xxxxxxxxxxxx> > > > --- > > net/netfilter/ipvs/ip_vs_lblc.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/net/netfilter/ipvs/ip_vs_lblc.c b/net/netfilter/ipvs/ip_vs_lblc.c > > index 3057e453bf31..83918119ceb8 100644 > > --- a/net/netfilter/ipvs/ip_vs_lblc.c > > +++ b/net/netfilter/ipvs/ip_vs_lblc.c > > @@ -371,6 +371,7 @@ static int ip_vs_lblc_init_svc(struct ip_vs_service *svc) > > tbl->counter = 1; > > tbl->dead = false; > > tbl->svc = svc; > > + atomic_set(&tbl->entries, 0); > > > > /* > > * Hook periodic timer for garbage collection > > -- > > 2.13.0 > > Regards > > -- > Julian Anastasov <ja@xxxxxx> > -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
