reproducible steps:
1. vgcreate vg1 /dev/sda /dev/sdb
2. lvcreate --type raid0 -l 100%FREE -n raid0lv vg1
3. do remove the /dev/sdb action
4. lvdisplay show wrong 'LV Status'
After removing raid0 type LV underlying dev, lvdisplay still display 'available'.
With this patch, lvdisplay will show
from:
LV Status available
to:
LV Status NOT available (partial)
Other LV type (like raid1, raid5), lvdisplay will show
from:
LV Status available
to:
LV Status available (partial)
Signed-off-by: Zhao Heming <heming.zhao@xxxxxxxx>
---
v2:
- add special handle for raid0 type.
- print 'partial' if lv is partial status.
- change comments, add raid0 & other raid types cases.
---
lib/display/display.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/lib/display/display.c b/lib/display/display.c
index 36c9879..0a37630 100644
--- a/lib/display/display.c
+++ b/lib/display/display.c
@@ -399,7 +399,7 @@ int lvdisplay_full(struct cmd_context *cmd,
void *handle __attribute__((unused)))
{
struct lvinfo info;
- int inkernel, snap_active = 0;
+ int inkernel, snap_active = 0, partial = 0, raid0_partial = 0;
char uuid[64] __attribute__((aligned(8)));
const char *access_str;
struct lv_segment *snap_seg = NULL, *mirror_seg = NULL;
@@ -553,11 +553,17 @@ int lvdisplay_full(struct cmd_context *cmd,
log_print("LV VDO Pool name %s", seg_lv(seg, 0)->name);
}
+ if (lv_is_partial(lv)) {
+ partial = 1;
+ if (lv_is_raid(lv) && seg_is_any_raid0(first_seg(lv)))
+ raid0_partial = 1;
+ }
if (inkernel && info.suspended)
log_print("LV Status suspended");
else if (activation())
- log_print("LV Status %savailable",
- inkernel ? "" : "NOT ");
+ log_print("LV Status %savailable %s",
+ (inkernel && !raid0_partial) ? "" : "NOT ",
+ partial ? "(partial)" : "");
/********* FIXME lv_number
log_print("LV # %u", lv->lv_number + 1);
--
1.8.3.1
_______________________________________________
linux-lvm mailing list
linux-lvm@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/linux-lvm
read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/
