On Thu, 2004-09-02 at 02:37, David S. Miller wrote: > On Tue, 31 Aug 2004 23:00:10 +0100 > Richard Mortimer <richm@oldelvet.org.uk> wrote: > > > How do they look > > Please resend your patch without all the line breaks > created by your email client. It looks fine otherwise > :) Bah. Clients are just getting too clever these days. Hopefully this should be ok. Richard --- arch/sparc64/kernel/ioctl32.c.orig 2004-08-29 00:12:09.000000000 +0100 +++ arch/sparc64/kernel/ioctl32.c 2004-08-31 22:06:23.000000000 +0100 @@ -2949,7 +2949,7 @@ case LV_REMOVE: case LV_RENAME: case LV_STATUS_BYNAME: - err = copy_from_user(&u.pv_status, arg, sizeof(u.pv_status.pv_name)); + err = copy_from_user(&u.lv_req, arg, sizeof(u.lv_req.lv_name)); if (err) return -EFAULT; if (cmd != LV_REMOVE) { @@ -2992,7 +2992,7 @@ case PV_CHANGE: case PV_STATUS: - err = copy_from_user(&u.pv_status, arg, sizeof(u.lv_req.lv_name)); + err = copy_from_user(&u.pv_status, arg, sizeof(u.pv_status.pv_name)); if (err) return -EFAULT; err = __get_user(ptr, &((pv_status_req32_t *)arg)->pv); @@ -3064,7 +3064,7 @@ if (u.lv_bydev.lv) { if (!err) err = copy_lv_t(ptr, u.lv_bydev.lv); - put_lv_t(u.lv_byindex.lv); + put_lv_t(u.lv_bydev.lv); } break; -- richm@oldelvet.org.uk _______________________________________________ linux-lvm mailing list linux-lvm@redhat.com https://www.redhat.com/mailman/listinfo/linux-lvm read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/