Re: [PATCH 2/2] hwmon: (nct6775) Add support for NCT6793D

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guenter,

On Mon, 31 Aug 2015 16:57:33 -0700, Guenter Roeck wrote:
> NCT6793D is register compatible with NCT6792D.
> 
> Tested-by: Grazvydas Ignotas <notasas@xxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
>  Documentation/hwmon/nct6775 |  4 ++++
>  drivers/hwmon/Kconfig       |  4 ++--
>  drivers/hwmon/nct6775.c     | 29 ++++++++++++++++++++++-------
>  3 files changed, 28 insertions(+), 9 deletions(-)
> (...)

Looks good to me (didn't check the datasheet, trusting you on the fact
that the chips are compatible) except that you forgot to add a name
string for the new chip to nct6775_sio_names[].

With that fixed:
Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

Note: given that enum kinds is used to index nct6775_sio_names[], it
would feel safer to have nct6775_sio_names[] defined closer to enum
kinds, as nct6775_device_names[] is already.

-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux