Re: [PATCH v2 5/5] hwmon: (it87) No need to skip fan4 for IT8603

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guenter,

On Wed, 25 Feb 2015 09:16:21 -0800, Guenter Roeck wrote:
> IT8603 supports only three fans, so it is not necessary to skip fan4.
> 
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> v2: Patch added to series
> 
>  drivers/hwmon/it87.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> index 691067b..ab12dc2 100644
> --- a/drivers/hwmon/it87.c
> +++ b/drivers/hwmon/it87.c
> @@ -1932,10 +1932,6 @@ static int __init it87_find(unsigned short *address,
>  		sio_data->skip_in |= (1 << 5); /* No VIN5 */
>  		sio_data->skip_in |= (1 << 6); /* No VIN6 */
>  
> -		/* no fan4 */
> -		sio_data->skip_pwm |= (1 << 3);
> -		sio_data->skip_fan |= (1 << 3);
> -
>  		sio_data->internal |= (1 << 1); /* in7 is VSB */
>  		sio_data->internal |= (1 << 3); /* in9 is AVCC */
>  

Looks good to me, good catch. Ruik, your ack would be appreciated.

Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux