Re: [PATCH v2 1/5] hwmon: (it87) Don't configure 16 bit fan counters it not necessary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 25 Feb 2015 09:16:17 -0800, Guenter Roeck wrote:
> On IT8728F, IT8771E, and IT8772E, fans counters are always 16 bit
> and don't need to be configured for it.
> 
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> v2: Separated changed functionality from 'Add feature flags' patch.
> 
>  drivers/hwmon/it87.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> index ed25e4b..e8cbefb 100644
> --- a/drivers/hwmon/it87.c
> +++ b/drivers/hwmon/it87.c
> @@ -2463,9 +2463,12 @@ static void it87_init_device(struct platform_device *pdev)
>  	}
>  	data->has_fan = (data->fan_main_ctrl >> 4) & 0x07;
>  
> -	/* Set tachometers to 16-bit mode if needed, IT8603E (and IT8728F?)
> -	 * has it by default */
> -	if (has_16bit_fans(data) && data->type != it8603) {
> +	/*
> +	 * Set tachometers to 16-bit mode if needed. IT8603E, IT8728F,
> +	 * IT8771E (guesswork), and IT8772E have it by default.
> +	 */
> +	if (has_16bit_fans(data) && data->type != it8603 && data->type != it8728
> +	    && data->type != it8771 && data->type != it8772) {
>  		tmp = it87_read_value(data, IT87_REG_FAN_16BIT);
>  		if (~tmp & 0x07 & data->has_fan) {
>  			dev_dbg(&pdev->dev,

Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

Thanks,
-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux