On Friday 26 December 2014 17:17:57 Tony Lindgren wrote: > * Tony Lindgren <tony@xxxxxxxxxxx> [141226 07:57]: > > * Pavel Machek <pavel@xxxxxx> [141226 02:32]: > > > --- /dev/null > > > +++ b/drivers/hwmon/omap34xx_temp.c > > > @@ -0,0 +1,263 @@ > > > +/* > > > + * omap34xx_temp.c - Linux kernel module for OMAP34xx > > > hardware monitoring + * > > > + * Copyright (C) 2008 Nokia Corporation > > > + * > > > + * Written by Peter De Schrijver > > > <peter.de-schrijver@xxxxxxxxx> + * > > > + * Inspired by k8temp.c > > > + * > > > + * This file is subject to the terms and conditions of > > > the GNU General + * Public License. See the file > > > "COPYING" in the main directory of this + * archive for > > > more details. > > > + * > > > + * This program is distributed in the hope that it will > > > be useful, + * but WITHOUT ANY WARRANTY; without even the > > > implied warranty of + * MERCHANTABILITY or FITNESS FOR A > > > PARTICULAR PURPOSE. See the + * GNU General Public > > > License for more details. > > > + */ > > > + > > > +#include <linux/clk.h> > > > +#include <linux/hrtimer.h> > > > +#include <linux/module.h> > > > +#include <linux/hwmon.h> > > > +#include <linux/hwmon-sysfs.h> > > > +#include <linux/err.h> > > > +#include <linux/platform_device.h> > > > +#include <linux/io.h> > > > +#include <linux/slab.h> > > > + > > > +#include "../../arch/arm/mach-omap2/control.h" > > > > No need to do this, you can use syscon here like > > pbias-regulator.c is doing. > > Oh looks like you're already using syscon, nice. What defines > do you need from control.h? > > Those should be in the driver if private to the driver, or > else we should have some minimal header in include/linux > somewhere if some control.h defines really need to be > exposed. > > Regards, > > Tony Hi Tony, Sebastian Reichel has already sent new version of temperature driver. See email thread with subject: [PATCH 0/3] OMAP3 temperature sensor -- Pali Rohár pali.rohar@xxxxxxxxx
Attachment:
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
