Re: [PATCH v2 2/2] hwmon: (lm95234) Add support for LM95233

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 30 Nov 2014 13:37:53 -0800, Guenter Roeck wrote:
> LM95233 is similar to LM95234, but it only supports two
> instead of four external temperature sensors.
> 
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> v2: Update Kconfig
>     Improve detection code (add more checks)
>     Update MODULE_DESCRIPTION
> 
>  Documentation/hwmon/lm95234 | 15 +++++---
>  drivers/hwmon/Kconfig       |  6 +--
>  drivers/hwmon/lm95234.c     | 91 ++++++++++++++++++++++++++++++++-------------
>  3 files changed, 78 insertions(+), 34 deletions(-)
> (...)
> diff --git a/drivers/hwmon/lm95234.c b/drivers/hwmon/lm95234.c
> index 411202b..af8fabd 100644
> --- a/drivers/hwmon/lm95234.c
> +++ b/drivers/hwmon/lm95234.c
> (...)
> @@ -622,15 +641,31 @@ static int lm95234_detect(struct i2c_client *client,
>  		return -ENODEV;
>  
>  	chip_id = i2c_smbus_read_byte_data(client, LM95234_REG_CHIP_ID);
> -	if (chip_id != LM95234_CHIP_ID)
> +	switch(chip_id) {

Missing space here again. Other than that:

Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux