Re: [PATCH 1/2] hwmon: (nct6775) Add support for NCT6792D

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guenter,

On Sun, 16 Nov 2014 10:15:13 -0800, Guenter Roeck wrote:
> NCT6792D is similar to NCT6791D. Only beep control and temperature
> monitoring registers are different.
> 
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
>  drivers/hwmon/nct6775.c | 47 +++++++++++++++++++++++++++++++++++++----------

Please also update Documentation/hwmon/nct6775 and
drivers/hwmon/Kconfig.

>  1 file changed, 37 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c
> index 504cbdd..ffe7427 100644
> --- a/drivers/hwmon/nct6775.c
> +++ b/drivers/hwmon/nct6775.c
> @@ -38,6 +38,7 @@
>   * nct6776f     9      5       3       6+3    0xc330 0xc1    0x5ca3
>   * nct6779d    15      5       5       2+6    0xc560 0xc1    0x5ca3
>   * nct6791d    15      6       6       2+6    0xc800 0xc1    0x5ca3
> + * nct6792d    15      6       6       2+6    0xc911 0xc1    0x5ca3

Given that all other chips have the device ID mask listed, maybe you
should do the same for the NCT6792D for consistency and list it as
0xc910?

Everything else looks good.

Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

Can you please also update wiki/Devices accordingly? I updated
sensors-detect already.

Thanks,
-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux