systemd integration: Problem with modprobe in lm_sensors.service

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I am running Fedora 16 with kernel 3.14.19-100.fc19.x86_64 and
systemd-204-21.fc19.x86_64.

On startup (and sometimes shutdown), I see a message like this in
/var/log/messages:

    Oct  6 13:53:37 hobgoblin modprobe[623]: modprobe: ERROR: missing parameters. See -h.

This message appears to be due to invocations of modprobe with these
arguments:

    /sbin/modprobe -qab
    /sbin/modprobe -qabr

Grepping all the system files (and looking in the journal), it seems
likely that these invocations are made by systemd, under control of
/usr/lib/systemd/system/lm_sensors.service:

    [Unit]
    Description=Initialize hardware monitoring sensors
    After=syslog.target

    [Service]
    EnvironmentFile=/etc/sysconfig/lm_sensors
    Type=oneshot
    RemainAfterExit=yes
    ExecStart=-/sbin/modprobe -qab $BUS_MODULES $HWMON_MODULES
    ExecStart=/usr/bin/sensors -s
    ExecStop=-/sbin/modprobe -qabr $BUS_MODULES $HWMON_MODULES

    [Install]
    WantedBy=multi-user.target

Which suggests that $BUS_MODULES and $HWMON_MODULES are empty in this
context.

I've found the threads "PATCH: systemd integration" and "PATCH:
systemd integration version 2".  But they don't deal with the fact
that modprobe prints an error message if the list of modules to be
loaded is empty.  Those error messages go into /var/log/messages, and
eventually logwatch sends e-mail to root complaining about them.

There doesn't seem to be a facility in systemd to optionally start a
program depending on settings in another file.  So maybe what is
needed are supporting scripts along these lines:

#! /bin/sh

if [ -n "$BUS_MODULES" -o -n "$HWMON_MODULES" ]
then
    /sbin/modprobe -qab $BUS_MODULES $HWMON_MODULES
fi

exec /usr/bin/sensors -s

and

#! /bin/sh

if [ -n "$BUS_MODULES" -o -n "$HWMON_MODULES" ]
then
    /sbin/modprobe -qabr $BUS_MODULES $HWMON_MODULES
fi

Dale

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux