Hi Guenter, On Tue, 18 Feb 2014 17:01:19 -0800, Guenter Roeck wrote: > Simplify code, reduce code size, and attach hwmon attributes to hwmon device. > > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> > --- > v2: The 'pec' attribute is still attached to the i2c device. > Reversed parameter order for lm90_init_client() All 4 patches look good, I've applied them all, thank you. > TBD: Should log messages be attached to the hwmon device ? > If so I'd probably submit a separate patch for it. To be honest I don't really care. > I tested this with MAX6695. Given that the pec attribute is now handled > differently, it might make sense to test this chip explicitly. > Jean, do you have one available, at least in simulation ? Unfortunately simulation is done using i2c-stub which lacks support for PEC, so it doesn't help. I do have a physical ADM1032 chip, however it is on a parallel-port evaluation board, and my workstation lacks such a port. I have one on another machine in my office, but it's running kernel 3.11 and the converted driver doesn't built there. So I'll have to build a new kernel on that old machine first. -- Jean Delvare Suse L3 Support _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
