On 07/05/2013 01:47 PM, Guenter Roeck wrote: > On Fri, Jul 05, 2013 at 11:35:05AM -0600, Stephen Warren wrote: >> On 07/04/2013 01:57 AM, Wei Ni wrote: >>> Add support to handle irq. When the temperature touch >>> the limit value, the driver can handle the interrupt. >> >>> + if (client->irq >= 0) { >> >> 0 isn't a valid IRQ, so you can write that as simply if (client->irq). >> > If I recall correctly, it is valid on some platforms. I thought ARM (just some ARM sub-architectures?) might have been the last architecture, and even irrespective of that, we were trying not to introduce any new code that relies on this strangeness, so it doesn't propagate? _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors