On Fri, Jun 28, 2013 at 02:05:26PM +0200, Jean Delvare wrote: > On Thu, 27 Jun 2013 10:12:51 -0700, Guenter Roeck wrote: > > On Thu, Jun 27, 2013 at 10:36:31AM +0200, Jean Delvare wrote: > > > This breaks limit rounding on the DS1621. Limits have a resolution of > > > 0.5°C on that chip, so limit values should rounded to the closest > > > half-degree. It used to work but no longer: if I write 20300 to > > > temp1_min, it is rounded down to 20000, while it should be rounded up > > > to 20500. > > > > Can you test the following patch ? It follows the logic implemented in the > > tmp401 driver. > > Tested OK, thanks :) > > Tested-by: Jean Delvare <khali@xxxxxxxxxxxx> > > And as the code looks sane too: > > Acked-by: Jean Delvare <khali@xxxxxxxxxxxx> > Thanks, to keep simple I'll add it on top of my -next tree instead of merging it. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors