Re: [PATCH 1/2] hwmon: (adm1021) Do not create min sysfs attributes for LM84

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 07, 2013 at 06:07:28PM +0200, Jean Delvare wrote:
> On Fri,  7 Jun 2013 08:51:19 -0700, Guenter Roeck wrote:
> > LM84 does not support minimum temperature registers.
> > Only create the respective sysfs attributes for other chips.
> 
> Did you consider implementing this with .is_visible()? This might
> result in a smaller binary.
> 
Hi Jean,

Turns out it is larger: 8575 bytes vs. 8516 bytes. Cost of cleaner code :(.

> Other than that, this looks good:
> 
> Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>
> 
Thanks - I'll keep it as-is (using multiple groups).

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux