On Mon, Oct 29, 2012 at 08:34:59AM +0100, Jean Delvare wrote: > On Sun, 28 Oct 2012 20:29:38 -0700, Guenter Roeck wrote: > > On Sun, Oct 28, 2012 at 10:39:54PM +0100, Jean Delvare wrote: > > > On Sun, 28 Oct 2012 11:19:53 -0700, Guenter Roeck wrote: > > > > +#define S_IRUGOWU (S_IRUGO | S_IWUSR) > > > > > > I'm not a big fan of this being defined in a single driver. If you > > > think it helps, then it would help several hundred drivers, not just > > > this one, so it should be defined in <linux/stat.h>, not locally. > > > > > It helps me avoid the 80-column limit later on. > > Line splits aren't that terrific, are they? > > Actually, as the maintainer of the it87 driver (just remembered that > tonight) I would prefer line splits to a driver-specific define using a > (kind of) general name-space. > Ok, I'll change it. > > I agree, it would be great to have this and similar definitions in > > a global include file, I am just not sure if there would be much > > of a chance to get it accepted there. > > Just try and see how your proposal is received? > Maybe ... Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
