On Sun, Oct 28, 2012 at 10:39:54PM +0100, Jean Delvare wrote: > On Sun, 28 Oct 2012 11:19:53 -0700, Guenter Roeck wrote: > > Cleaner code, fewer checkpatch errors, and reduced code size > > (saves more than 500 bytes on x86-64). > > I like the idea. > Thanks ... [ ... ] > > +#define S_IRUGOWU (S_IRUGO | S_IWUSR) > > I'm not a big fan of this being defined in a single driver. If you > think it helps, then it would help several hundred drivers, not just > this one, so it should be defined in <linux/stat.h>, not locally. > It helps me avoid the 80-column limit later on. I agree, it would be great to have this and similar definitions in a global include file, I am just not sure if there would be much of a chance to get it accepted there. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
