On Tue, 2012-05-15 at 14:21 -0400, Jean Delvare wrote: > On Tue, 15 May 2012 19:25:03 +0200, Björn Gerhart wrote: > > From: Bjoern Gerhart <oss@xxxxxxxxxxxxx> > > > > Drop UART6 condition for IT8783F related to VIN5 and VIN6. > > In case UART6 is routed via JP4 to a different set of pins, > > VIN5 and VIN6 can be used at the same time. > > > > diff -Naur a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c > > --- a/drivers/hwmon/it87.c 2012-05-15 16:53:07.156061059 +0200 > > +++ b/drivers/hwmon/it87.c 2012-05-15 17:19:31.717061875 +0200 > > @@ -1806,11 +1806,11 @@ > > sio_data->skip_pwm |= (1 << 1); > > > > /* VIN5 */ > > - if ((reg27 & (1 << 0)) || uart6) > > + if (reg27 & (1 << 0)) > > sio_data->skip_in |= (1 << 5); /* No VIN5 */ > > > > /* VIN6 */ > > - if ((reg27 & (1 << 1)) || uart6) > > + if (reg27 & (1 << 1)) > > sio_data->skip_in |= (1 << 6); /* No VIN6 */ > > > > /* > > > > What about FAN3_TAC? As I read the datasheet, it is also "freed" if > UART6 is moved to pins 100-106. So I suspect we don't want to check for > uart6 at all for the IT8783F. > > This all would better be done directly in Guenter's patch, BTW, as it > isn't upstream yet. > Let me look at it again tonight. The fan3 test is "|| !uart6", so it is the opposite. I am getting more and more confused :(. I'll have to re-read the data sheet to see what is going on. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
