Hi Guenter, On Sat, 24 Mar 2012 08:45:07 -0700, Guenter Roeck wrote: > In some configurations, BUG() does not result in an endless loop but returns to > the caller. This results in the following compiler warning: > > drivers/hwmon/f75375s.c: In function 'duty_mode_enabled': > drivers/hwmon/f75375s.c:280: warning: control reaches end of non-void function > drivers/hwmon/f75375s.c: In function 'auto_mode_enabled': > drivers/hwmon/f75375s.c:295: warning: control reaches end of non-void function > > Fix the warning by returning something sensible after BUG(). > > Cc: Nikolaus Schulz <schulz@xxxxxxxxxxx> > Cc: Riku Voipio <riku.voipio@xxxxxx> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> > --- > drivers/hwmon/f75375s.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c > index 729499e..ece4159 100644 > --- a/drivers/hwmon/f75375s.c > +++ b/drivers/hwmon/f75375s.c > @@ -276,6 +276,7 @@ static bool duty_mode_enabled(u8 pwm_enable) > return false; > default: > BUG(); > + return true; > } > } > > @@ -291,6 +292,7 @@ static bool auto_mode_enabled(u8 pwm_enable) > return true; > default: > BUG(); > + return false; > } > } Acked-by: Jean Delvare <khali@xxxxxxxxxxxx> -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
