On Sat, Mar 24, 2012 at 03:45:43PM -0400, Roland Stigge wrote: > Hi, > > On 24/03/12 20:12, Guenter Roeck wrote: > >> --- linux-2.6.orig/drivers/hwmon/max6639.c > >> +++ linux-2.6/drivers/hwmon/max6639.c > >> @@ -596,6 +596,7 @@ static int max6639_remove(struct i2c_cli > >> return 0; > >> } > >> > >> +#ifdef CONFIG_PM > > > > Looking into other drivers, I think that should be CONFIG_PM_SLEEP > > Which other drivers did you mean? > > What about those drivers that all handle it via CONFIG_PM: > > abituguru.c > abituguru3.c > exynos4_tmu.c > gpio-fan.c > jc42.c > lm75.c > tmp102.c > > ? Those drivers don't use SET_SYSTEM_SLEEP_PM_OPS. I checked several drivers which do use SET_SYSTEM_SLEEP_PM_OPS, and they all use CONFIG_PM_SLEEP. > > >> +#else > >> +#define max6639_suspend NULL > >> +#define max6639_resume NULL > >> +#endif > >> > > ... and that else case should not be necessary. > The drivers using SET_SYSTEM_SLEEP_PM_OPS don't define the else case. Thanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
