On Sat, Mar 24, 2012 at 02:36:08PM -0400, Roland Stigge wrote:
> This patch fixes a compiler warning in case CONFIG_PM is not defined
>
> Signed-off-by: Roland Stigge <stigge@xxxxxxxxx>
>
> ---
>
> This solves the issue recently encountered by Kurt Roeck in the nightly build.
>
> The solution with #ifdef's is done as in all the other drivers.
>
> drivers/hwmon/max6639.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> --- linux-2.6.orig/drivers/hwmon/max6639.c
> +++ linux-2.6/drivers/hwmon/max6639.c
> @@ -596,6 +596,7 @@ static int max6639_remove(struct i2c_cli
> return 0;
> }
>
> +#ifdef CONFIG_PM
Looking into other drivers, I think that should be CONFIG_PM_SLEEP
> static int max6639_suspend(struct device *dev)
> {
> struct i2c_client *client = to_i2c_client(dev);
> @@ -617,6 +618,10 @@ static int max6639_resume(struct device
> return i2c_smbus_write_byte_data(client,
> MAX6639_REG_GCONFIG, data & ~MAX6639_GCONFIG_STANDBY);
> }
> +#else
> +#define max6639_suspend NULL
> +#define max6639_resume NULL
> +#endif
>
... and that else case should not be necessary.
Oh well, now I ended up looking into it anyway ... so I just added the missing #ifdef to Mark's patch.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
