Re: [PATCH v3] hwmon: (lm87) Fix checkpatch issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 25 Jan 2012 08:26:46 -0800, Guenter Roeck wrote:
> From: Guenter Roeck <linux@xxxxxxxxxxxx>
> 
> Fixed:
> ERROR: do not use assignment in if condition
> ERROR: space required after that close brace '}'
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: spaces required around that '<' (ctx:VxV)
> ERROR: trailing statements should be on next line
> WARNING: line over 80 characters
> WARNING: simple_strtol is obsolete, use kstrtol instead
> WARNING: simple_strtoul is obsolete, use kstrtoul instead
> 
> Modify multi-line comments to follow Documentation/CodingStyle.
> 
> Not fixed everywhere (code complexity):
> ERROR: do not use assignment in if condition
> 
> As a side effect of the changes made, attribute set functions now return an
> error if an attempt is made to write a non-numeric value. Previously, such
> writes were interpreted as writing 0.
> 
> Cc: Jean Delvare <khali@xxxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> v2: Merged checkpatch and multi-line comment patches into a single patch
> v3: Fixed some alignment issues. Added note to commit log describing that
>     set functions now return error codes.
> 
>  drivers/hwmon/lm87.c |  257 ++++++++++++++++++++++++++++++++++----------------
>  1 files changed, 174 insertions(+), 83 deletions(-)
> 
> diff --git a/drivers/hwmon/lm87.c b/drivers/hwmon/lm87.c
> index 126d0cc..0216592 100644
> --- a/drivers/hwmon/lm87.c
> +++ b/drivers/hwmon/lm87.c
> (...)

Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux