if there is an error it is better to set data->valid to 0 so the next call to ltc4261_update_device will always be executed Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@xxxxxxxxx> --- patch is against the hwmon staging tree git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git as retrieved on jan 2, 2012 drivers/hwmon/ltc4261.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/hwmon/ltc4261.c b/drivers/hwmon/ltc4261.c index 4b50601..ce52355 100644 --- a/drivers/hwmon/ltc4261.c +++ b/drivers/hwmon/ltc4261.c @@ -85,6 +85,7 @@ static struct ltc4261_data *ltc4261_update_device(struct device *dev) "Failed to read ADC value: error %d\n", val); ret = ERR_PTR(val); + data->valid = 0; goto abort; } data->regs[i] = val; -- 1.7.0.4 _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
