On Mon, 29 Aug 2011 08:11:46 -0700, Guenter Roeck wrote: > On Mon, 2011-08-29 at 07:42 -0400, Jean Delvare wrote: > > Clean up the code to make it more readable: > > * Remove reg_ and new_ prefixes from variable names, they made the > > names longer, causing extra line breaks, while not adding much > > value. > > * Introduce struct device dev* = &client->dev in two functions, to > > avoid repeating client->dev everywhere in these functions. > > > > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx> > > Hi Jean, > > Nitpick: You could probably merge several of the multi-line if > statements into a single line or at least into fewer lines. Not sure if > you did not do that on purpose, so > > Acked-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx> You are right, and yes this was left as is on purpose. These could have been merged even before shortening the variable names, but I think it is easier to validate the checks done for every chip type with one check per line. Thanks for the reviews, -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
