Re: [PATCH 2/2] hwmon: (lm90) Make code more readable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2011-08-29 at 07:42 -0400, Jean Delvare wrote:
> Clean up the code to make it more readable:
> * Remove reg_ and new_ prefixes from variable names, they made the
>   names longer, causing extra line breaks, while not adding much
>   value.
> * Introduce struct device dev* = &client->dev in two functions, to
>   avoid repeating client->dev everywhere in these functions.
> 
> Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>

Hi Jean,

Nitpick: You could probably merge several of the multi-line if
statements into a single line or at least into fewer lines. Not sure if
you did not do that on purpose, so

Acked-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>

Guenter



_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux