Re: [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/23/2011 5:28 AM, Kevin Hilman wrote:
Rajendra Nayak<rnayak@xxxxxx>  writes:

[...]

FWIK, its a one time requirement to set the clock rate to the
right rate the device can operate in based on what a platform
supports.

Except $SUBJECT patch hard-codes the clock rate for all platforms in the
driver.

The device has a requirement to operate in a 1Mhz to 2Mhz range. So the
driver is using a clk_round_rate() to get the closest rate supported and
sets it using a clk_set_rate().


If the clock rate is to be platform-specific, it should be done in
platform-specific code.

I am fine if this needs to be moved to platform-specific code, but I
wasn't quite sure this needs to be done in clock framework as was
suggested.


Kevin


_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux