On Tue, Jul 12, 2011 at 12:45:22PM -0400, Jean Delvare wrote: > On Tue, 12 Jul 2011 09:40:33 -0700, Guenter Roeck wrote: > > On Tue, Jul 12, 2011 at 05:01:52AM -0400, Jean Delvare wrote: > > > We can allocate the tx and rx buffers as part of our data structure. > > > Doing so is faster and spares memory. > > > > > > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx> > > > --- > > > Can anyone with a MAX1111 device try and report please? > > > > > Reason for using allocated buffers may have been to ensure (word/cache line) alignment. > > Not really sure if that is a valid argument with 1/2 byte buffers, though. > > And such an alignment would belong to the bus driver rather than the > SPI device driver. At least this is the way we do it for I2C... > Possibly, and makes sense (how does the device driver know ?), but for USB they had me do it in the I2C master driver ... I ensured alignment by placing the buffers at the beginning of the allocated memory. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
