Re: [PATCH] hwmon: (max1111) Avoid extra memory allocations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 12 Jul 2011 09:40:33 -0700, Guenter Roeck wrote:
> On Tue, Jul 12, 2011 at 05:01:52AM -0400, Jean Delvare wrote:
> > We can allocate the tx and rx buffers as part of our data structure.
> > Doing so is faster and spares memory.
> > 
> > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
> > ---
> > Can anyone with a MAX1111 device try and report please?
> > 
> Reason for using allocated buffers may have been to ensure (word/cache line) alignment.
> Not really sure if that is a valid argument with 1/2 byte buffers, though.

And such an alignment would belong to the bus driver rather than the
SPI device driver. At least this is the way we do it for I2C...

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux