On Tue, 2011-06-28 at 13:50 -0400, Fubo Chen wrote:
> On Mon, Jun 27, 2011 at 9:04 AM, Stijn Devriendt (sdevrien)
> <sdevrien@xxxxxxxxx> wrote:
> >> On Mon, Jun 6, 2011 at 12:40 PM, <sdevrien@xxxxxxxxx> wrote:
> >> > + } else
> >> > + if (man_id == 0xA1) { /* NXP Semiconductor/Philips */
> >>
> >> No kernel coder writes like this. Has this ever been run through
> >> checkpatch ?
> > It has. Unfortunately this is just the coding style in the whole
> > driver. I believe it's better to have a consistent file rather
> > than 3 different styles.
>
> Makes sense to me. By the way, it's not forbidden to clean up unusual
> coding style from other developers.
>
Yes, but as separate patch. Please feel free to submit such a patch.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
