Re: [PATCH v3] Add support for the Philips SA56004 temperature sensor.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 27, 2011 at 9:04 AM, Stijn Devriendt (sdevrien)
<sdevrien@xxxxxxxxx> wrote:
>> On Mon, Jun 6, 2011 at 12:40 PM,  <sdevrien@xxxxxxxxx> wrote:
>> > +       } else
>> > +       if (man_id == 0xA1) { /*  NXP Semiconductor/Philips */
>>
>> No kernel coder writes like this. Has this ever been run through
>> checkpatch ?
> It has. Unfortunately this is just the coding style in the whole
> driver. I believe it's better to have a consistent file rather
> than 3 different styles.

Makes sense to me. By the way, it's not forbidden to clean up unusual
coding style from other developers.

Fubo.

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux