Re: max1668 support revisited

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 01, 2011 at 10:02:36AM -0400, David George wrote:
> Hi Guentor.
> 
> Thanks for all the feedback. I have attached a patch for your approval.
> 
> > The easiest way to proceed would be for you to read and follow the guidelines
> > in Documentation/hwmon/submitting-patches; this would also save us a lot of time.
> 
> I have tried to follow the guidelines as best I can. I still have
> checkpatch errors and warnings for:
> *  do not use assignment in if condition
> * consider using kstrto* in preference to simple_strtol
> I notices that other drivers do the same thing so I figured it may be okay.
> 
Not for new drivers, and we appreciate patch submissions for existing ones. 
[ No, it is not legal to drive above the speed limit, even if everyone does it. ]

I'll have a look.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux