On Tue, 24 May 2011 10:10:05 -0700, Guenter Roeck wrote: > On Mon, May 23, 2011 at 12:31:08PM -0400, Jean Delvare wrote: > > This is a new driver for the SMSC EMC6W201 hardware monitoring device. > > The device is functionally close to the EMC6D100 series, but is > > register-incompatible. > > > > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx> > > Tested-by: Harry G McGavran Jr <w5pny@xxxxxxxxx> > > Tested-by: Jeff Rickman <jrickman@xxxxxxxxxxx> > > Only concern I have is that you don't always validate error returns from > i2c_smbus_read_byte_data(). If an error occurs, this will result in odd > temperature and voltage readings. Not sure if that is a real problem, so Probably not a big deal in practice, but you're right, it is inconsistent and could be improved. I'll submit a patch today. Thanks for the review! -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
