Re: [PATCH] hwmon: New driver for the SMSC EMC6W201

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 23, 2011 at 12:31:08PM -0400, Jean Delvare wrote:
> This is a new driver for the SMSC EMC6W201 hardware monitoring device.
> The device is functionally close to the EMC6D100 series, but is
> register-incompatible.
> 
> Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
> Tested-by: Harry G McGavran Jr <w5pny@xxxxxxxxx>
> Tested-by: Jeff Rickman <jrickman@xxxxxxxxxxx>

Only concern I have is that you don't always validate error returns from
i2c_smbus_read_byte_data(). If an error occurs, this will result in odd
temperature and voltage readings. Not sure if that is a real problem, so

Acked-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux