On Wed, 6 Apr 2011 10:17:53 -0700, Guenter Roeck wrote: > When writing hardware monitoring drivers, there are some common pitfalls which > keep coming up in code reviews. This patch provides a document describing all > those pitfalls and how to avoid them. > > Signed-off-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx> Acked-by: Jean Delvare <khali@xxxxxxxxxxxx> Minor suggestion below - but no need to resend. > +* Provide a detect function only if a chip can be detected reliably. On the > + other side, if the chip can be detected reliably, provide a detect function. Could be expressed in a more compact way as: * Provide a detect function if and only if a chip can be detected reliably. (But maybe this is the mathematician in me speaking!) -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors