Hi Andreas, On Wed, 6 Apr 2011 16:00:26 +0200, Andreas Herrmann wrote: > On Wed, Apr 06, 2011 at 03:17:36PM +0200, Jean Delvare wrote: > > Except for the Family 10h case which is more complex, AMD CPU sensor > > detection is straightforward, so we don't really need a dedicated > > function for each CPU family. By passing the expected F3 PCI device ID > > as a parameter, we can use the same function for all families. > > > > Objection anyone? This could be seen as moving some of the detection > > code into @cpu_ids itself, but OTOH it saves quite a few lines of > > redundant code. > > No objections -- of cours, it's a good idea. > > BTW, detection for "AMD Family 15h thermal sensors" can also be used > for f15h_power (once the driver is accepted/integrated). Yes and no. A similar logic can be used, but the PCI device ID is different. Will you send a patch, or should I add it myself? -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
