Re: [PATCH 2/2 v2] hwmon: twl4030: Hwmon Driver for TWL4030 MADC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 28, 2011 at 9:11 AM, Guenter Roeck
<guenter.roeck@xxxxxxxxxxxx> wrote:
> On Sun, Feb 27, 2011 at 08:03:07PM -0500, Samuel Ortiz wrote:
>> Hi Keerthy,
>>
>> On Thu, Feb 24, 2011 at 08:48:50PM +0530, Keerthy wrote:
>> > This driver exposes the sysfs nodes of the TWL4030 MADC module.
>> > All the voltage channel values are expressed in terms of mV. Channel 13
>> > and channel 14 are reserved. There are channels which represent
>> > temperature and current the output is represented by celcius
>> > and mA respectively.
>> It would make sense for me to carry both patches through the MFD tree, but
>> I'd like to get Guenter's ACK before pushing it upstream.
>>
> Main problem I have with the hwmon part is the sensor index value
> and how it maps to adc channels. Specifically, channels 13 and 14 are
> listed as reserved, yet index value 13 is used without further explanation
> as bit map value passed on to twl4030_madc_conversion() to obtain the value
> for channel 15. Either this is wrong, or it asks for a detailed explanation.
> I didn't have time to track down which one it is. And even if it isn't wrong,
> it doesn't seem to be the right thing to do since it adds a lot of confusion.
>
> Guenter
>

Guenter,

It should be 15. I will repost with the changed value.
Sorry for the confusion.

Regards,
Keerthy



-- 
Regards and Thanks,
Keerthy

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux