On Wed, Nov 10, 2010 at 12:14:38PM -0500, Henrik Rydberg wrote: > >> > > >> Looking at this again, it seems there are two other problems as well. Firstly, > >> the cache memory is not freed after probe failure, my apologies. Secondly, > >> execution continues after a probe failure, and the initialization is retried. I > >> would like to push the latter problem to some other occasion, since the whole > >> platform logic should be rewritten for the new interface, anyways. > >> > > I see the cache problem; this is indeed a tricky one, since it is actually not yet > > a problem after this patch, but will be one after patch 5. > > > > I don't understand the second problem, though. Looking into the code, > > the probe function will return an error if applesmc_init_smcreg() fails. > > Am I missing something ? What execution continues ? > > > I think drivers/base/dd.c:142 shows the problem clearly. Basically, the probe > function is supposed to do the proper initialization, if successful. The driver > code has been rewritten heavily since the days of the applesmc, and the actual > probe error is now masked in a rather ugly fashion to allow the driver matching > to continue. It seems to me that the only clean way around this is to actually > implement the correct platform driver logic. > Ok, guess there is nothing we can do about that. I'll apply the rest of your series. Thanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
