On Tue, 2010-11-09 at 15:15 -0500, Luca Tettamanti wrote: > On Tue, Nov 9, 2010 at 5:37 PM, Guenter Roeck > <guenter.roeck@xxxxxxxxxxxx> wrote: > > On Wed, Oct 20, 2010 at 06:51:30AM -0000, Joe Perches wrote: > >> Added #define pr_fmt KBUILD_MODNAME ": " fmt > >> Converted printks to pr_<level> > >> Coalesced any long formats > >> Removed prefixes from formats > >> > >> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> > >> > > Applied. > > > > On a side note, I let the long lines go through as long as checkpatch doesn't complain. > > I lost sight of the discussion, but I thought that a better solution > was to put the define for pr_fmt in a common header instead of > scattering it in all the drivers. > We went back and forth on it, and concluded that Joe's current approach, while not optimal, is still the best - ie make the changes as he proposed and get rid of the pr_fmt defines at the very end, after all individual files have been changed. Everything else is just too intrusive. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
