Re: [PATCH] hwmon: (ltc4261) Fix error message format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2010-11-05 at 12:39 -0400, Jean Delvare wrote:
> On Fri, 5 Nov 2010 09:31:20 -0700, Guenter Roeck wrote:
> > On Fri, 2010-11-05 at 10:59 -0400, Jean Delvare wrote:
> > > adapter->id is deprecated and not set by any adapter driver, so this
> > > was certainly not what the author wanted to use. adapter->nr maybe,
> > > but as dev_err() already includes this value, as well as the client's
> > > address, there's no point repeating them. Better print a simple error
> > > message in plain English words.
> > > 
> > > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
> > > Cc: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>
> > 
> > Acked-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>
> > 
> > No idea where I got that from.
> 
> Do you want to take this patch in your tree, or shall I?
> 
Let me take it into my tree. I have another one-line patch for the same
driver in there already anyway, so we can avoid conflicts.

Guenter



_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux