On Sun, Oct 31, 2010 at 03:50:33AM -0400, Henrik Rydberg wrote:
> Given the dynamic node construction method, the setup of the
> accelerometer, light sensor and keyboard backlight sysfs nodes
> can be simplified. This patch does not contain any logic changes.
>
> Signed-off-by: Henrik Rydberg <rydberg@xxxxxxxxxxx>
Hi Henrik,
only one minor comment.
> ---
> drivers/hwmon/applesmc.c | 168 ++++++++++++++++++++-------------------------
> 1 files changed, 75 insertions(+), 93 deletions(-)
>
> diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c
> index 4ba20ec..c09cd2e 100644
> --- a/drivers/hwmon/applesmc.c
> +++ b/drivers/hwmon/applesmc.c
[ ... ]
> +static struct applesmc_node_group info_group[] = {
> + { "name", applesmc_name_show },
> + { "key_count", applesmc_key_count_show },
> + { "key_at_index", applesmc_key_at_index_show, applesmc_key_at_index_store },
Finally a checkpatch warning - line longer than 80 columns.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
