Hi Simon,
On Thu, 2010-10-21 at 18:44 -0400, Simon Guinot wrote:
> From: Simon Guinot <sguinot@xxxxxxxxx>
>
> This patch adds hwmon support for the GPIO connected fan.
>
I rephrased this to ".. for fans connected to GPIO pins."
> Platform specific informations as GPIO pinout and speed conversion array
> (rpm from/to GPIO value) are passed to the driver via platform_data.
>
> Signed-off-by: Simon Guinot <sguinot@xxxxxxxxx>
[ ... ]
> +static int __devinit gpio_fan_probe(struct platform_device *pdev)
> +{
> + int err = 0;
and this variable initialization is not needed.
Otherwise looks good. Applied with the above changed to my -next tree.
I'll let it rest there for a couple of days. Unless some unforeseen
problems show up, it might just make it into .37.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
