Hi Jean, > -----Original Message----- > From: Jean Delvare [mailto:khali@xxxxxxxxxxxx] > Sent: Friday, August 27, 2010 6:15 PM > To: Datta, Shubhrajyoti > Cc: lm-sensors@xxxxxxxxxxxxxx > Subject: Re: [RFC PATCH] Trivial changes to pacify the > checkpatch > > Hi Shubhrajyoti, > > On Thu, 26 Aug 2010 19:03:17 +0530, Shubhrajyoti D wrote: > > Some trivial changes to pacify the checkpatch so that > > real errors are highlighted. > > > > Signed-off-by: Shubhrajyoti D <shubhrajyoti@xxxxxx> > > --- > > drivers/hwmon/lm75.c | 40 ++++++++++++++++++++-------------------- > > 1 files changed, 20 insertions(+), 20 deletions(-) > > > > diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c > > index d579290..97b3a89 100644 > > --- a/drivers/hwmon/lm75.c > > +++ b/drivers/hwmon/lm75.c > > @@ -1,21 +1,21 @@ > > /* > > - lm75.c - Part of lm_sensors, Linux kernel modules for hardware > > - monitoring > > - Copyright (c) 1998, 1999 Frodo Looijaard <frodol@xxxxxx> > > - > > - This program is free software; you can redistribute it and/or > modify > > - it under the terms of the GNU General Public License as published > by > > - the Free Software Foundation; either version 2 of the License, or > > - (at your option) any later version. > > - > > - This program is distributed in the hope that it will be useful, > > - but WITHOUT ANY WARRANTY; without even the implied warranty of > > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > - GNU General Public License for more details. > > - > > - You should have received a copy of the GNU General Public License > > - along with this program; if not, write to the Free Software > > - Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > > + lm75.c - Part of lm_sensors, Linux kernel modules for hardware > > + monitoring > > + Copyright (c) 1998, 1999 Frodo Looijaard <frodol@xxxxxx> > > + > > + This program is free software; you can redistribute it and/or modify > > + it under the terms of the GNU General Public License as published by > > + the Free Software Foundation; either version 2 of the License, or > > + (at your option) any later version. > > + > > + This program is distributed in the hope that it will be useful, > > + but WITHOUT ANY WARRANTY; without even the implied warranty of > > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + GNU General Public License for more details. > > + > > + You should have received a copy of the GNU General Public License > > + along with this program; if not, write to the Free Software > > + Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > > */ > > > > #include <linux/module.h> > > @@ -339,9 +339,9 @@ static struct i2c_driver lm75_driver = { > > > > /* register access */ > > > > -/* All registers are word-sized, except for the configuration register. > > - LM75 uses a high-byte first convention, which is exactly opposite to > > - the SMBus standard. */ > > +/* All registers are word-sized, except for the configuration register. > > + LM75 uses a high-byte first convention, which is exactly opposite to > > + the SMBus standard. */ > > static int lm75_read_value(struct i2c_client *client, u8 reg) > > { > > int value; > > That's not the right fix, sorry. The right way would be to add stars: > > /* > * All registers are word-sized, except for the configuration register. > * LM75 uses a high-byte first convention, which is exactly opposite to > * the SMBus standard. > */ > > Same for the first comment. Agree will fix it. > > -- > Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
