On Wed, Mar 31, 2010 at 8:55 AM, Jonathan Cameron <jic23@xxxxxxxxx> wrote: > On 03/31/10 16:02, Paul Thomas wrote: >> Great, just a couple of responses. >> > > ... > >>>> +static const struct attribute_group ads7871_group = { >>>> + .attrs = ads7871_attributes, >>>> +}; >>>> + >>>> +static int __devinit ads7871_probe(struct spi_device *spi) >>>> +{ >>>> + int status, ret, err = 0; >>>> + uint8_t val; >>>> + struct ads7871_data *pdata; >>>> + >>> There is still a lot of debug code in here that is useful for development >>> but probably doesn't want to be in the final driver. >> I'm happy with what you think is best, but in other driver I've been >> glad to have a little bit in demesg. > Fair enough. How much you report tends to be a personal decision, so > it's fine with me as is. > > Jonathan > Is there a staging git tree for hwmon? I see this: http://lm-sensors.org/kernel, but both branches look old. Should I cc another mailing list with this patch? I'm just trying to understand how the flow between hwmon and the upstream kernel stuff works. thanks, Paul _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors