Re: [PATCH] V3, TI ads7871 a/d converter, formatting cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/31/10 16:02, Paul Thomas wrote:
> Great, just a couple of responses.
> 

...

>>> +static const struct attribute_group ads7871_group = {
>>> +     .attrs = ads7871_attributes,
>>> +};
>>> +
>>> +static int __devinit ads7871_probe(struct spi_device *spi)
>>> +{
>>> +     int status, ret, err = 0;
>>> +     uint8_t val;
>>> +     struct ads7871_data *pdata;
>>> +
>> There is still a lot of debug code in here that is useful for development
>> but probably doesn't want to be in the final driver.
> I'm happy with what you think is best, but in other driver I've been
> glad to have a little bit in demesg.
Fair enough.  How much you report tends to be a personal decision, so
it's fine with me as is.

Jonathan

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux