Op 12-02-10 07:31, samu.p.onkalo@xxxxxxxxx schreef: >> The only hiccup is in patch 6: it declares the joystick with 3 buttons, >> although on this hardware it's impossible to have this feature. So, it >> would be nice if input_set_capability() could be conditionned. > > I'll add configuration option to platform data or do you prefer some other > way to enable this? > You obviously meant that enable those only for 8 bit device, since > 12 bit doesn't have click detection. I can do that. > Perfect! >> I also fully agree with the comments from others that it would be better >> if it could use the special runtime power-management framework from >> Rafael. > > It looks like the corrent way to do that. However, I don't have suitable environment > to do that right now. I need to study this more if I can somehow verify it. That would be great :-) > BTW, what is exactly the usecase for the "active" sysfs >> attribute? To me, it looks like it just prevents userspace from using >> the position attribute, while the joystick interface is still >> accessible, so it is not very effective! > > That is exactly what it does. Input and freefall interfaces control the chip state > separately. So, this is only for sysfs interface since driver doesn't know > if somebody is using sysfs interface. > > So this is the logic: > - If application wants to use sysfs, it must set 'active' to 1 (which is the default to > maintain backward compatibility). > Otherwise chip state is controlled by the number of users in > input and freefall device handles. > When 'active' is 0, only input / freefall device handles controls > the chip state. > > When active is 0 but chip is enabled via input / freefall entries, > position entry returns error code. This is done to prevent the case where > chip is suddenly powered down when input / freefall devices are closed. > So position entry is working only when it is separately enabled. > > When there are no users at all, chip is powered down. > I understand. The main problem is that powering up and down the chip every time someone opens the sysfs position attribute is very expensive. Having an explicit attribute to turn on/off the powersaving means that the userspace must be aware of it. This is a burden, and especially if you run your userspace application as a normal user, while the active attribute obviously requires root level. Previously, when I implemented the auto power down feature, I had put a timer after 30s of usage to work around this. It's obviously not optimal, but it has the advantage of hiding completely the powersaving feature from userspace. Do you think it would be fine it implement it this way? See you, Eric _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
