Hi Roger, On Fri, 11 Dec 2009 18:54:54 -0800 (PST), roger blofeld wrote: > The ADT7462_PIN28_VOLT value is a 4-bit field, so the corresponding shift must be 4. > > Signed-off-by: Roger Blofeld <blofeldus@xxxxxxxxx> > --- > My mailer will whitespace damage the inline copy of the patch. > The attached version should be OK. > > diff --git a/drivers/hwmon/adt7462.c b/drivers/hwmon/adt7462.c > index 1852f27..262c133 100644 > --- a/drivers/hwmon/adt7462.c > +++ b/drivers/hwmon/adt7462.c > @@ -97,7 +97,7 @@ I2C_CLIENT_INSMOD_1(adt7462); > #define ADT7462_PIN24_SHIFT 6 > #define ADT7462_PIN26_VOLT_INPUT 0x08 > #define ADT7462_PIN25_VOLT_INPUT 0x20 > -#define ADT7462_PIN28_SHIFT 6 /* cfg3 */ > +#define ADT7462_PIN28_SHIFT 4 /* cfg3 */ > #define ADT7462_PIN28_VOLT 0x5 > > #define ADT7462_REG_ALARM1 0xB8 Correct. Applied, thanks. -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors